[CLEANUP] Removes various deprecated APIs #17845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
force-pushed
the
cleanup/remove-deprecated-apis
branch
from
56fbe98 to
630a2a8
Compare
rwjblue
approved these changes
Apr 3, 2019
|
These definitely should not be picked onto the release at least for now, they break ED. I'm investigating whether the error is in our test suite or something deeper |
|
I think it might be only ED tests doing bad things, but I'll confirm once fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also unsure if these should be picked onto the release, like #17843. We should really make deprecations hard fail as soon as they reach their
untilversion, if they don't already.