[BUGFIX beta] Fix template-only components clearing #17846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not all the tests failed as intended because of #17847 |
The root cause is when the `createInstance` flag is disabled, Glimmer omits the `DidRenderLayout` opcode, which has the unintended consequence of skipping the `popBlock` call, causing an imbalance in the stack. This means additional content unrelated to the component will be treated as part of the component's bounds, causing other errors later on. It also causes other issues such as blocks not getting finalized due to the unbalanced push and pops.
wycats
force-pushed
the
template-only-bounds
branch
from
d788b91 to
c0aa717
Compare
Looks like it really _needs_ to be true for input and root anyway.
chancancode
changed the title
rwjblue
approved these changes
Apr 3, 2019
|
Can you also create an issue for the underlying problem over in glimmer-vm? |
|
@rwjblue I'm going to get that fixed today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause is when the
createInstanceflag is disabled, Glimmer omits theDidRenderLayoutopcode, which has the unintended consequence of skipping thepopBlockcall, causing an imbalance in the stack. This means additional content unrelated to the component will be treated as part of the component's bounds, causing other errors later on. It also causes other issues such as blocks not getting finalized due to the unbalanced push and pops.