Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "splattributes" class merging #17870

Merged
merged 3 commits into from
Apr 6, 2019
Merged

Fix "splattributes" class merging #17870

merged 3 commits into from
Apr 6, 2019

Conversation

chancancode
Copy link
Member

@chancancode chancancode commented Apr 6, 2019

Fixes #17533

If we upgrade stable/LTS to @glimmer/* 0.38, we should apply this patch to those branches too. (cc @rwjblue)

Need triage to see if these are talking about the same issue:

Maybe more?

chancancode and others added 2 commits April 5, 2019 17:45
When a `class=` attribute comes _after_ `...attributes`, we don't merge it correctly. Instead it gets clobbered.

This PR adds failing tests.
(beta will need a different version)

Closes #17533, #17692.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants