Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Fix for #17869 (link-to causing hash local variable assertions) #17872

Merged
merged 2 commits into from
Apr 6, 2019

Conversation

chancancode
Copy link
Member

@chancancode chancancode commented Apr 6, 2019

This doesn't really "fix" the issue, it just silent this particular assertion basically. This is ok, because the test will fail when we implement the "everything is a value" semantics, at which point we can fix it by renaming the hash helper. (We could fix it now by renaming the offending hash local variable too, but that would be pretty difficult to do correctly.)

…tions)

This doesn't really "fix" the issue, it just silent this particular
assertion basically. This is ok, because the test will fail when we
implement the "everything is a value" semantics, at which point we
can fix it by renaming the hash helper. (We could fix it now by
renaming the offending hash local variable too, but that would be
pretty difficult to do correctly.)

Closes #17869.
@chancancode chancancode merged commit b40fdb3 into beta Apr 6, 2019
@chancancode chancancode deleted the fix-17869 branch April 6, 2019 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant