-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Update docs to show deprecate
function within @ember/debug
package
#17926
Conversation
According to https://github.com/ember-cli/ember-rfc176-data, the current documentation is the correct one, so I'm closing this PR. |
@locks - The documentation is wrong for |
Specifically, importing While researching I found a number of (pretty prominent) addons using 🤔 |
Hm, should we come up with an action plan next framework meeting? |
Ya, sounds good. I think either way we need to make both imports work (and have the stripping behaviors), but seems like a great thing to discuss more broadly. |
We discussed this during today's Ember core team meeting:
|
added deprecations ember-cli/ember-rfc176-data#140, |
@bekzod - We also need to make ember-cli-babel have the same stripping in prod behaviors for @ember/application/deprecations stuff |
Ok will add then |
ember-cli-babel was updated in https://github.com/babel/ember-cli-babel/releases/tag/v7.8.0 |
All the pieces are in place now, this should be good to go now. |
Thanks @elwayman02 / @xg-wang / @bekzod for pushing this forward! |
These were incorrectly documented as being part of this package for a long time, and so the types included them; but this was fixed as of Ember 3.12 (in [this PR][1]), three and a half years ago, and our types never got the message! 😬 [1]: emberjs/ember.js#17926
These were incorrectly documented as being part of this package for a long time, and so the types included them; but this was fixed as of Ember 3.12 (in [this PR][1]), three and a half years ago, and our types never got the message! 😬 [1]: emberjs/ember.js#17926
These were incorrectly documented as being part of this package for a long time, and so the types included them; but this was fixed as of Ember 3.12 (in [this PR][1]), three and a half years ago, and our types never got the message! 😬 [1]: emberjs/ember.js#17926
These were incorrectly documented as being part of this package for a long time, and so the types included them; but this was fixed as of Ember 3.12 (in [this PR][1]), three and a half years ago, and our types never got the message! 😬 [1]: #17926
…ctions by @chriskrycho These were incorrectly documented as being part of this package for a long time, and so the types included them; but this was fixed as of Ember 3.12 (in [this PR][1]), three and a half years ago, and our types never got the message! 😬 [1]: emberjs/ember.js#17926
The current docs show it within the
@ember/application/deprecations
package, when it physically lives within@ember/debug
.Fixes #17185
cc: @rwjblue