Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Expose mechanism to detect if a property is a computed. #17938

Merged
merged 1 commit into from
Apr 23, 2019

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Apr 17, 2019

This adds a private/intimate method for use by the ember-inspector (and possibly other tools) to aid the migration to native decorator version of computed (since computed(function() {}) instanceof ComputedProperty is no longer usable).

From the docs:

Allows checking if a given property on an object is a computed property. For the most part, this doesn't matter (you would normally just access the property directly and use its value), but for some tooling specific scenarios (e.g. the ember-inspector) it is important to differentiate if a property is a computed property or a "normal" property.

Copy link
Member

@RobbieTheWagner RobbieTheWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@RobbieTheWagner
Copy link
Member

@rwjblue @pzuraq Do we have an ETA on when this might be merged?

This adds a private/intimate method for use by the ember-inspector
(and possibly other tools) to aid the migration to native decorator
version of `computed` (since `computed(function() {}) instanceof
ComputedProperty` is no longer usable).

From the docs:

```md
Allows checking if a given property on an object is a computed property.
For the most part, this doesn't matter (you would normally just access
the property directly and use its value), but for some tooling specific
scenarios (e.g. the ember-inspector) it is important to differentiate if
a property is a computed property or a "normal" property.
```
@rwjblue rwjblue merged commit 2cc3573 into emberjs:master Apr 23, 2019
@rwjblue rwjblue deleted the is-computed branch April 23, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants