-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX release] Ensure query param only link-to's work in error states. #17971
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix seems reasonable (thank you!), but I think we need to add a previously failing test to ensure we don't regress again...
cd43696
to
21edc29
Compare
I try to add one test in "packages/@ember/-internals/glimmer/tests/integration/components/link-to/query-params-curly-test.js", but with no success. The test need an @rwjblue Do you have any idea on how to write this previously failing test? Thank you! |
we are trying fix this on engines side as well - ember-engines/ember-engines#647 |
@2hu12 unfortunately I don't was able to write tests for this =/ |
… route. Reproduce failure in emberjs#17963: `<LinkTo>` without `@route` param but with `@query` breaks when navigating to error route. Co-authored-by: Robert Jackson <me@rwjblue.com>
thanks @rwjblue |
Try to fix #17963, I'm not sure this is the right way and it's weird, but the old "qualifiedRouteName" property works in this way and "_route" is used similarly to "qualifiedRouteName".