Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Adds sync observers back to tracked properties #18059

Merged
merged 1 commit into from
May 29, 2019
Merged

[FEATURE] Adds sync observers back to tracked properties #18059

merged 1 commit into from
May 29, 2019

Commits on May 29, 2019

  1. [FEATURE] Adds sync observers back to tracked properties 

    This PR flushes synchronous observers in the tracked feature flag path
during each `notifyPropertyChange`, which gives these observers similar
timing semantics to what they currently have without the feature flag
enabled. These changes are meant to only affect observers, and while the
metadata required is stored with listeners, this PR doesn't add "async
listeners" as a concept to the system.

The most notable change is the addition of the `suspended` property to
active observers. This property is used by setters which are being set
(computed property setters, and in the future `dependentKeyCompat`
setters), and when observers are triggered to prevent re-entry.
    Chris Garrett committed May 29, 2019
    Configuration menu
    Copy the full SHA
    0ce0174 View commit details
    Browse the repository at this point in the history