Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated NAME_KEY #18124

Merged
merged 1 commit into from
Jun 26, 2019
Merged

remove deprecated NAME_KEY #18124

merged 1 commit into from
Jun 26, 2019

Conversation

bekzod
Copy link
Contributor

@bekzod bekzod commented Jun 20, 2019

No description provided.

@rwjblue
Copy link
Member

rwjblue commented Jun 20, 2019

packages/@ember/-internals/utils/index.ts:42:1 - error TS6133: 'symbol' is declared but its value is never read.
42 import symbol from './lib/symbol';
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Found 1 error.

@bekzod
Copy link
Contributor Author

bekzod commented Jun 20, 2019

Thanks @rwjblue , fixed issue above and test passing

@locks locks requested a review from rwjblue June 21, 2019 08:02
@pzuraq pzuraq merged commit 8b90e83 into emberjs:master Jun 26, 2019
@pzuraq
Copy link
Contributor

pzuraq commented Jun 26, 2019

thanks @bekzod!

@bekzod bekzod deleted the remove-name-key branch June 26, 2019 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants