Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ember-cli-htmlbars for inline precompilation if possible. #18410

Merged
merged 1 commit into from
Sep 19, 2019

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Sep 18, 2019

ember-cli-htmlbars@4.0.0+ provides the ability to do inline precompilation out of the box (no need for a separate addon), this updates our test generator to import from the right place and avoid installing the second addon if we don't need it.

ember-cli-htmlbars@4.0.0+ provides the ability to do inline
precompilation out of the box (no need for a separate addon), this
updates our test generator to import from the right place and avoid
installing the second addon if we don't need it.
@rwjblue rwjblue merged commit 7e89ec1 into emberjs:master Sep 19, 2019
@rwjblue rwjblue deleted the inline-precompile-source branch September 19, 2019 13:00
@@ -70,20 +75,32 @@ module.exports = useTestFrameworkDetector({
return {
path: getPathOption(options),
testType: testType,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can also be shortened

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point, mind sending in a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants