Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate {{partial}} #18491

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Deprecate {{partial}} #18491

merged 1 commit into from
Oct 25, 2019

Conversation

GavinJoyce
Copy link
Member

@GavinJoyce GavinJoyce commented Oct 14, 2019 •
edited
Loading

Part of emberjs/rfc-tracking#38
Supersedes #14972

TODO:

@locks locks self-assigned this Oct 14, 2019
@GavinJoyce GavinJoyce mentioned this pull request Oct 15, 2019
Merged
4 tasks
@GavinJoyce GavinJoyce force-pushed the gj/deprecate-partial branch 2 times, most recently from 0dd69ec to f6fda97 Compare October 24, 2019 13:40
@GavinJoyce GavinJoyce mentioned this pull request Oct 24, 2019
Merged
@GavinJoyce GavinJoyce changed the title [WIP] deprecate partials Deprecate {{partial}} Oct 24, 2019
@GavinJoyce GavinJoyce mentioned this pull request Oct 24, 2019
Closed
2 tasks
rwjblue
rwjblue reviewed Oct 25, 2019
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think there is a way to make it so all of packages/@ember/-internals/views/lib/system/lookup_partial.js can be stripped (aka svelted)? Can we inline that module into here:

https://github.com/emberjs/ember.js/blob/ee8a894980fad6664a26ba78c8d949891abf811b/packages/%40ember/-internals/glimmer/lib/resolver.ts

And remove the various reexports and whatnot?

@GavinJoyce GavinJoyce force-pushed the gj/deprecate-partial branch from b7123ac to ff9e96b Compare October 25, 2019 08:41
@GavinJoyce
Copy link
Member Author

GavinJoyce commented Oct 25, 2019 •
edited
Loading

Good call, I've moved lookup_partial.js into resolver.ts and wrapped it for svelting

rwjblue
rwjblue approved these changes Oct 25, 2019
View reviewed changes
packages/@ember/-internals/glimmer/lib/resolver.ts
assert(`templateNames are not allowed to contain periods: ${name}`, name.indexOf('.') === -1);

if (!owner) {
throw new EmberError(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error is a bit "wild", but 🤷‍♂

@rwjblue rwjblue merged commit fb91c8a into emberjs:master Oct 25, 2019
@rwjblue
Copy link
Member

rwjblue commented Oct 25, 2019

Thank you!

@GavinJoyce GavinJoyce deleted the gj/deprecate-partial branch October 25, 2019 18:47
@rwjblue rwjblue mentioned this pull request Nov 18, 2019
Merged
2 tasks
@kennethlarsen kennethlarsen mentioned this pull request Nov 28, 2019
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees

@locks locks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GavinJoyce @rwjblue @locks