Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX release] Add component reference to the mouse event handler deprecation warnings #18549

Merged
merged 1 commit into from
Nov 15, 2019

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 15, 2019

This makes the deprecations a lot more actionable because it's easier to see what component is causing the deprecation without having to open the debugger.

I've targeted the release branch with this PR. I hope that's okay... 🙏

@rwjblue
Copy link
Member

rwjblue commented Nov 15, 2019

I've targeted the release branch with this PR. I hope that's okay... 🙏

Would you mind updating to point at master and labeling the commit message with [BUGFIX release] please?

…eprecation warnings

This makes the deprecations a lot more actionable because it's easier to see what component is causing the deprecation without having to open the debugger.
@Turbo87 Turbo87 changed the base branch from release to master November 15, 2019 16:29
@Turbo87
Copy link
Member Author

Turbo87 commented Nov 15, 2019

done

@rwjblue rwjblue changed the title component: Add component reference to the mouse event handler deprecation warnings [BUGFIX release] Add component reference to the mouse event handler deprecation warnings Nov 15, 2019
@rwjblue rwjblue merged commit fcba68d into emberjs:master Nov 15, 2019
@rwjblue
Copy link
Member

rwjblue commented Nov 15, 2019

Thank you!

@Turbo87 Turbo87 deleted the deprecations branch November 20, 2019 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants