Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX release] Consumes tags after fully getting values #18668

Merged
merged 1 commit into from
Jan 16, 2020
Merged

[BUGFIX release] Consumes tags after fully getting values #18668

merged 1 commit into from
Jan 16, 2020

Commits on Jan 10, 2020

  1. [BUGFIX release] Consumes tags after fully getting values 

    Currently get() consumes some tags before getting the values,
and getting the values itself can cause tag changes and notifications.
In some cases, this is invalid, because the value that is being notified
hasn't actually been consumed yet (it is in the process of being
consumed. More generally, consumption should always occur immediately
_after_ the relevant calculation - in this case, the getter.
    Chris Garrett committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    34facf1 View commit details
    Browse the repository at this point in the history