[BUGFIX release] Updated blueprints for component and helper tests to output the correct hbs import statement #18691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijlee2
commented
Jan 19, 2020
| return true; | ||
| } else if (semver.gte(htmlbarsAddon.pkg.version, '4.0.0-alpha.1')) { |
There was a problem hiding this comment.
Line 94 implies that, if the version is ember-cli-htmlbars is 3.x or less, we will still use the named import (because we are returning undefined, a falsey value). Could you verify if this was intended or a bug?
There was a problem hiding this comment.
3.x should use import hbs from 'htmlbars-inline-precompile', which AFAICT is still what is done after this change.
… output the correct hbs import statement
ijlee2
changed the title
rwjblue
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #18626.
Tests
I wanted to write tests per contributing guide, but couldn't figure out how to make
this.project.addonsincludeember-cli-htmlbarsin a test. Currently, there isn't a test that checks the component test when the version ofember-cli-htmlbarsis at least4.0.0-alpha.1, so I didn't have an example that I could follow.It seemed like
ember-cli-blueprint-test-helperscurrently doesn't support updating theaddonsattribute (https://github.com/ember-cli/ember-cli-blueprint-test-helpers/blob/master/lib/modify-packages.js#L20-L26). If I missed something and settingaddonsis possible, please let me know and I'd be happy to add tests.I did manually test locally using
yarn link ember-sourceon a new Ember 3.15 project. If the version ofember-cli-htmlbarsis at least4.0.0-alpha.1, the generators will add the named import statement. If the version is less, or ifember-cli-htmlbarsdoesn't exist, the generators will add the default import statement.