Merge pull request #18707 from emberjs/bugfix/fix-object-proxy-tags #18707
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Proxy mixin uses the private
UNKNOWN_PROPERTY_TAG
APIto provide the tags for the content property that the mixin is proxying
to. However, previously the chains system would do this and still
entangle changes to the local property. This allowed users to manually
notify in subclasses of Proxy.
This PR adds the tag for the property back to the returned tag, so it
works the same as before. It also refactors
setupMandatorySetter
,since we now have to do that work in two places (to avoid re-entry).
Fixes #18704