[BUGFIX release] Ensures the arg proxy works with get
#18708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the arg proxy used a custom system for passing along its `capturedArgs` directly to `getChainTags`, in order to interoperate with computed properties. As it turns out, there are a number of other places where the correct tag needs to be gotten and setup. This PR replaces the `UNKNOWN_PROPERTY_TAG` system with a more general `CUSTOM_TAG_FOR` system. In this system, if we detect that an object has this method, we defer to it to get the tag, even if the property was defined on the object. There are two users of this system: - ProxyMixin - The arg proxy Given that it's private, and we have relatively few use cases, I believe this is the cleanest solution at the moment. The alternative would be to keep `UNKNOWN_PROPERTY_TAG` and also add `CUSTOM_TAG_FOR`, but that seems unnecessary given low usage.
pzuraq
force-pushed
the
bugfix/ensure-args-proxy-works-with-get
branch
from
fe4c13d to
6e8eb68
Compare
rwjblue
approved these changes
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the arg proxy used a custom system for passing along its
capturedArgsdirectly togetChainTags, in order to interoperate withcomputed properties. As it turns out, there are a number of other places
where the correct tag needs to be gotten and setup.
This PR replaces the
UNKNOWN_PROPERTY_TAGsystem with a more generalCUSTOM_TAG_FORsystem. In this system, if we detect that an object hasthis method, we defer to it to get the tag, even if the property was
defined on the object. There are two users of this system:
Given that it's private, and we have relatively few use cases, I believe
this is the cleanest solution at the moment. The alternative would be to
keep
UNKNOWN_PROPERTY_TAGand also addCUSTOM_TAG_FOR, but thatseems unnecessary given low usage.
Fixes #18606