Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX lts] Revert container deprecation #18729

Merged
merged 1 commit into from
Feb 8, 2020

Conversation

chancancode
Copy link
Member

We agreed that it was important to fix the error cases in #18717, but while the work may be unnecessary, there isn't necessarily any "correctness" issues with looking up things during destruction. Using a deprecation to warn about potentially "unnecessary" work is a bit heavy-handed, and at minimum requires some more continued discussions, so reverting that part of the PR for now (while keeping the errors intact).

We agreed that it was important to fix the error cases in #18717, but
while the work may be unnecessary, there isn't necessarily any
"correctness" issues with looking up things during destruction. Using
a deprecation to warn about potentially "unnecessary" work is a bit
heavy-handed, and at minimum requires some more continued discussions,
so reverting that part of the PR for now (while keeping the errors in
tact).
@chancancode chancancode requested a review from rwjblue February 7, 2020 23:19
@chancancode chancancode merged commit 1b853e1 into master Feb 8, 2020
@chancancode chancancode deleted the revert-container-derecation branch February 8, 2020 01:24
});
}

'@test instantiating via container.lookup during destruction enqueues destruction'(assert) {
Copy link
Member

@rwjblue rwjblue Feb 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test should not have been removed. It is testing that things looked up during destruction are properly destroyed (aka the “correctness” fix mentioned in the PR description).

This should have removed the expectDeprecation wrapper around the lookup (since there is no deprecation now) but not the test assertions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants