[BUGFIX release] Fix setDiff computed macro used within glimmer component #18742
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
setDiff
computed macro within a glimmer component is failing due tothis.get
being unaccessible within that scope.Replacing the
this.get
with theget
imported from@ember/-internals/metal
just as in every other macros fixes the issue.As every
reduce_computed_macros
tests are within theobject
folder, I didn't really know where to create the new failing test for the current issue, as it seems related to the usage of a glimmer component. If anyone have any idea on how and where we should create a test for this, I'd be interested to know.To reproduce the issue, create a glimmer component and use the setDiff computed macro:
And then trigger the computation of the
wants
property. This will be resulting in the following error: