[BUGFIX beta] Adding tests for #18732 #18751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancancode
changed the base branch from
bugfix/upgrade-glimmer-vm-0.47.9
to
master
|
Changing the base branch to master temporarily to confirm the tests do fail |
|
Hm. I guess that doesn't work |
chancancode
force-pushed
the
bugfix/upgrade-glimmer-vm-0.47.9
branch
from
712da09
to
699439c
Compare
chancancode
force-pushed
the
bugfix/upgrade-glimmer-vm-0.47.9
branch
from
699439c
to
004cea1
Compare
|
Ok I think I did it (sorry, had to force push to your branch). If it fails correctly, I think we can just change the base branch back to @pzuraq's branch. (I haven't looked at the actual tests being added yet.) |
|
@chancancode It failed, however, I'm unsure whether it failed expectedly. |
rwjblue
changed the base branch from
master
to
bugfix/upgrade-glimmer-vm-0.47.9
|
Failure looks like I’d expect, updating target branch back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BUGFIX beta] Adding tests for #18732