Ensure the test suite runs with Octane's set of optional features. #18782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
test-edition-properly
branch
from
14dc2fe to
cfb74eb
Compare
rwjblue
commented
Feb 28, 2020
This comment has been minimized.
This comment has been minimized.
rwjblue
force-pushed
the
test-edition-properly
branch
from
cfb74eb to
7403b31
Compare
Prior to these change we would only run the test suite in "classic" mode, and did not run the tests with the combination of octane optional features setup. This adds a new test run for "classic", and makes the default test run use "octane"'s set of optional features.
rwjblue
force-pushed
the
test-edition-properly
branch
from
7403b31 to
bdc17b0
Compare
When there is no wrapping element around the top level outlet, the debug render tree assertions need to tweaked.
These tests were attempting to modify the `ENV._TEMPLATE_ONLY_GLIMMER_COMPONENTS` value at runtime, but load different code when it is and isn't set. So now that the test suite is setting `template-only-glimmer-components` when the Ember code loads we can no longer "fake" these tests. However, the changes to the test runner mean that we still test this both on and off so we are not loosing coverage.
rwjblue
force-pushed
the
test-edition-properly
branch
from
bdc17b0 to
2f817cc
Compare
krisselden
approved these changes
Feb 28, 2020
| var edition = QUnit.urlParams.edition || 'octane'; | ||
|
|
||
| if (edition === 'octane') { | ||
| EmberENV._TEMPLATE_ONLY_GLIMMER_COMPONENTS = true; |
There was a problem hiding this comment.
is there a source of truth for this? not a big deal if not just curious
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to these change we would only run the test suite in "classic" mode,
and did not run the tests with the combination of octane optional features
setup.
This adds a new test run for "classic", and makes the default test run use
"octane"'s set of optional features.