Add a simple (failing) test for named block usage #18852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should pass once #18869 is landed and this is rebased. |
|
OK, ready for a rebase. |
locks
force-pushed
the
simple-named-blocks-test
branch
from
efc8019
to
8bd4d2d
Compare
|
Rebased! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a conversation in Discord with @rwjblue and @locks yesterday, it sounds like the level of effort needed to get named blocks working in Ember at this point is a known-unknown.
Just to get the ball rolling, I pulled together a simple test gated on the
EMBER_NAMED_BLOCKSfeature. What I found was that basic usage appears to work for template-only components and theGlimmerishComponenttest backing class, but not with Ember components.Unfortunately my knowledge of the VM is minimal enough that I don't have much of a clue why that's the case, but hopefully it's at least a useful data point for someone who knows more than me 😄