[FEATURE deprecate-get-with-default] Deprecate getWithDefault

[chrisrng]

Based on RFC 0554

Also added:
ember-learn/deprecation-app#600

[elwayman02]

Thank you! It was confusing seeing the docs not show this as deprecated.

[rwjblue]

I think we also need to deprecate this.getWithDefault (I suspect this deprecation does fire in that case, but the docs at least need to be updated):

ember.js/packages/@ember/-internals/runtime/lib/mixins/observable.js

Lines 415 to 423 in fc9afa5

	@method getWithDefault
	@param {String} keyName The name of the property to retrieve
	@param {Object} defaultValue The value to return if the property value is undefined
	@return {Object} The property value or the defaultValue.
	@public
	*/
	getWithDefault(keyName, defaultValue) {
	return getWithDefault(this, keyName, defaultValue);
	},

[chrisrng]

I think we also need to deprecate this.getWithDefault (I suspect this deprecation does fire in that case, but the docs at least need to be updated):

ember.js/packages/@ember/-internals/runtime/lib/mixins/observable.js

Lines 415 to 423 in fc9afa5

	@method getWithDefault
	@param {String} keyName The name of the property to retrieve
	@param {Object} defaultValue The value to return if the property value is undefined
	@return {Object} The property value or the defaultValue.
	@public
	*/
	getWithDefault(keyName, defaultValue) {
	return getWithDefault(this, keyName, defaultValue);
	},

Ah yeah added the doc here!

[rwjblue]

The link doesn't work just yet, do we expect it to be live already?

[rwjblue]

Oh I see, I just merged ember-learn/deprecation-app#600. Once that is published and we can validate the URL is working as expected this should good to go...

[chrisrng]

Works now! :)