[BUGFIX lts] Prevent <base target="_parent"> from erroring in HistoryLocation
#19059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ryLocation It is perfectly valid to have a `<base>` element without an `href` attribute but the code previously assumed that if a `<base>` was present that it **must** contain an `href`. Specifically, prior to this change if you had a `<base>` like: ```html <base target="_parent"> ``` You would get the following error: ``` Uncaught TypeError: Cannot read property 'replace' of null ``` See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/base for more details on usage of `<base>` without an `href`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is perfectly valid to have a
<base>element without anhrefattribute but the code previously assumed that if a<base>was present that it must contain anhref.Specifically, prior to this change if you had a
<base>like:You would get the following error:
See on MDN for more details on usage of
<base>without anhref.Fixes #19038