[BUGFIX release] Simplify get and computeds #19077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
force-pushed
the
refactor/better-get
branch
from
f834114
to
72d0216
Compare
krisselden
reviewed
Aug 5, 2020
pzuraq
force-pushed
the
refactor/better-get
branch
from
72d0216
to
c30f896
Compare
|
Benchmark results against current master of Ember and Glimmer VM: |
pzuraq
force-pushed
the
refactor/better-get
branch
from
c30f896
to
21589e4
Compare
pzuraq
changed the title
pzuraq
force-pushed
the
refactor/better-get
branch
2 times, most recently
from
2d7373d
to
4543f51
Compare
krisselden
reviewed
Aug 6, 2020
krisselden
reviewed
Aug 6, 2020
krisselden
approved these changes
Aug 6, 2020
This refactor simplifies get and computeds in the following ways:
- Removes several brand checks that were unnecessary from `get`:
- `isEmberArray`: Ember Arrays that are not native arrays will
automatically be tracked through proper usage.
- `isProxy`: This was only necessary for conditionals, and updates in
the VM allow us to autotrack that instead.
- Uses `tagFor` instead of `tagForProperty` in many places including
`get`. This allows us to avoid the brand check for
`CUSTOM_PROPERTY_TAG`, which is really only necessary for chain tags.
- Updates everywhere that looks up tags multiple times on the same
object to use a shared `tagMeta` so we don't lookup that map multiple
times.
- Moves computed revision and value caches onto Meta, so we're looking
up fewer maps.
- Creates a new AutoComputed descriptor for computed properties that
use autotracking, so we can simplify the get logic for standard CPs.
pzuraq
force-pushed
the
refactor/better-get
branch
from
4543f51
to
e69b6f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor simplifies get and computeds in the following ways:
get:isEmberArray: Ember Arrays that are not native arrays willautomatically be tracked through proper usage.
isProxy: This was only necessary for conditionals, and updates inthe VM allow us to autotrack that instead.
tagForinstead oftagForPropertyin many places includingget. This allows us to avoid the brand check forCUSTOM_PROPERTY_TAG, which is really only necessary for chain tags.object to use a shared
tagMetaso we don't lookup that map multipletimes.
up fewer maps.
use autotracking, so we can simplify the get logic for standard CPs.