Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass transition object to activate/deactivate hooks and events #19086

Merged
merged 1 commit into from
Aug 7, 2020
Merged

Pass transition object to activate/deactivate hooks and events #19086

merged 1 commit into from
Aug 7, 2020

Conversation

mehulkar
Copy link
Contributor

@mehulkar mehulkar commented Aug 7, 2020

Closes #19022

@rwjblue rwjblue merged commit e463258 into emberjs:master Aug 7, 2020
@rwjblue
Copy link
Member

rwjblue commented Aug 7, 2020

Thank you!

@mehulkar mehulkar deleted the mk/19022 branch August 7, 2020 22:28
@locks locks mentioned this pull request Oct 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] activate hook doesn't receive transition as an argument
2 participants
@mehulkar @rwjblue