[FEAT] Implements Helper Managers #19160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
force-pushed
the
feat/implement-helper-managers
branch
2 times, most recently
from
1f00e0e
to
ff4dd17
Compare
pzuraq
force-pushed
the
feat/implement-helper-managers
branch
from
ff4dd17
to
fe9474d
Compare
rwjblue
force-pushed
the
feat/implement-helper-managers
branch
5 times, most recently
from
4ee4f62
to
0adf544
Compare
pzuraq
commented
Sep 29, 2020
rwjblue
force-pushed
the
feat/implement-helper-managers
branch
from
0adf544
to
87a4f93
Compare
pzuraq
force-pushed
the
feat/implement-helper-managers
branch
from
87a4f93
to
f15ca15
Compare
Implements the helper manager feature specified in RFC 625. Highlights: 1. Adds `getDebugName` to the interface for helper managers. This is an optional hook that is used for better logging purposes, and matches other internal APIs we've added recently. 2. `hasScheduledEffect` has not yet been implemented, and attempting to use it will cause an assertion to be thrown. Helper managers are not exposed with this PR, and the version passed to `helperCapabilities` is optimistic, but can be changed when we do expose them (along with an appropriate feature flag). Co-authored-by: Robert Jackson <me@rwjblue.com>
pzuraq
force-pushed
the
feat/implement-helper-managers
branch
from
f15ca15
to
be95475
Compare
rwjblue
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the helper manager feature specified in RFC 625. Highlights:
Adds
getDebugNameto the interface for helper managers. This is an optional hook that is used for better logging purposes, and matches other internal APIs we've added recently.hasScheduledEffecthas not yet been implemented, and attempting to use it will cause an assertion to be thrown.Helper managers are not exposed with this PR, and the version passed to
helperCapabilitiesis optimistic, but can be changed when we do expose them (along with an appropriate feature flag).