Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Enables Helper Managers and invokeHelper #19182

Merged
merged 1 commit into from
Oct 3, 2020

Conversation

pzuraq
Copy link
Contributor

@pzuraq pzuraq commented Oct 3, 2020

Enables the Helper Manager and invokeHelper feature flags, and adds
API documentation for them.

export function invokeHelper(
context: object,
definition: HelperDefinition,
computeArgs: (context: object) => Partial<Arguments>
computeArgs?: (context: object) => Partial<Arguments>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mistake in the typings here but the SimpleArgsProxy had the correct typings

@pzuraq pzuraq force-pushed the enable-helper-managers-invoke-helper branch 2 times, most recently from 7f14b2a to a5bdd26 Compare October 3, 2020 17:01
@pzuraq
Copy link
Contributor Author

pzuraq commented Oct 3, 2020

Failures are due to inconsistent error messages across browsers for assigning a value on a frozen object, going to update that test to just ensure that args are frozen using Object.isFrozen

Enables the Helper Manager and `invokeHelper` feature flags, and adds
API documentation for them.
@pzuraq pzuraq force-pushed the enable-helper-managers-invoke-helper branch from a5bdd26 to efd895f Compare October 3, 2020 17:27
@pzuraq pzuraq merged commit 575f479 into master Oct 3, 2020
@pzuraq pzuraq deleted the enable-helper-managers-invoke-helper branch October 3, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants