Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX lts] Restores the shadowed property set behavior #19197

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

pzuraq
Copy link
Contributor

@pzuraq pzuraq commented Oct 13, 2020

Restores the previous behavior that would happen when setting a shadowed
property.

Fixes #19179 on release/lts

Restores the previous behavior that would happen when setting a shadowed
property.
@pzuraq pzuraq force-pushed the bugfix/restore-shadowed-property-set-behavior branch from 4cc6078 to d3fcd07 Compare October 13, 2020 22:12
@rwjblue
Copy link
Member

rwjblue commented Oct 14, 2020

@pzuraq - Can you update the description here with cross links to the relevant threads (the PR that made this change initially, the issue that was reported after that landed, etc). As it stands, this will be hard to connect the dots in a few weeks/months.

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Please don't forget to update the description with links to the related PRs and issues...

@rwjblue rwjblue merged commit c863ee4 into release Oct 14, 2020
@rwjblue rwjblue deleted the bugfix/restore-shadowed-property-set-behavior branch October 14, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants