Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX release] QP's bug for intermediate transitions #19249

Conversation

rreckonerr
Copy link
Contributor

@rreckonerr rreckonerr commented Nov 5, 2020

Information

This is to make sure that tildeio/router.js#308 covers bug that resulted in missing query params in certain scenarios. Since there's a bunch of issues related to this bug we should write and combine failing tests together in this PR and land them after tildeio/router.js#308 is released.

Related issues

TODOs

@rreckonerr rreckonerr changed the title [BUGFIX] Failing test cases for intermediateTransition QP's bug [BUGFIX] QP's bug for intermediate transitions Nov 6, 2020
@rwjblue rwjblue changed the title [BUGFIX] QP's bug for intermediate transitions [BUGFIX release] QP's bug for intermediate transitions Nov 6, 2020
@rwjblue
Copy link
Member

rwjblue commented Nov 6, 2020

Great work, thanks for working through this!

@rreckonerr
Copy link
Contributor Author

My pleasure :)

@sly7-7
Copy link
Contributor

sly7-7 commented Mar 4, 2021

@rwjblue The tests are not enough here, and unfortunately, there is still a bug somewhere, but I think it's hard to reproduce in tests. I've investigated a bit, and found that during an intermediate transition (at least when I have an explicit loading template), although the url is still with the correct qp values, the controller properties of these qps are reset to their default values, and thus update the (parent) template. When the 'loading' transition is over, then the qps are back to their expected 'updated' values, and the templates update accordingly.

As a workaround, I've removed the loading template, and used a loading action to manually manage a loading flag in the parent controller, and conditionnaly display either the {{outlet}} or a loading component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants