Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC #481] change return of getComponentTemplate from null to undefined to align with RFC #19253

Merged
merged 1 commit into from
Nov 9, 2020
Merged

[RFC #481] change return of getComponentTemplate from null to undefined to align with RFC #19253

merged 1 commit into from
Nov 9, 2020

Conversation

jamescdavis
Copy link
Contributor

From RFC #481:

The getComponentTemplate function takes a component class and returns the template associated with the given component class, if any, or one of its superclasses, if any, or undefined if no template association was found.

/cc @chancancode

@jamescdavis jamescdavis mentioned this pull request Nov 6, 2020
Closed
10 tasks
chancancode
chancancode approved these changes Nov 6, 2020
View reviewed changes
Copy link
Member

@chancancode chancancode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rwjblue do you think anything else may care?

@pzuraq
Copy link
Contributor

pzuraq commented Nov 6, 2020 •
edited
Loading

I this was an intentional divergence from the RFC in order to align with the the setManager APIs, and it would be breaking to change this.

I'm sorry, I read this as setComponentTemplate, not getComponentTemplate. I'm unsure if this would be breaking.

@rwjblue rwjblue merged commit cb5b67e into emberjs:master Nov 9, 2020
@pzuraq pzuraq mentioned this pull request Nov 10, 2020
Merged
@jamescdavis jamescdavis deleted the align_getComponentTemplate_return_with_rfc branch December 10, 2020 17:51
@locks locks mentioned this pull request Jan 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chancancode chancancode chancancode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamescdavis @pzuraq @chancancode @rwjblue