[Bug]: route serialize does not extract param off proxy

[snewcomer]

close emberjs/data#7380

name in model does not work with our content in a Proxy.

This does not work where tag is a ED relationship on @model.

<LinkTo @route="tag" @model={{@model.tag}}>{{@model.tag.title}}</LinkTo>

Uncaught Error: Assertion Failed: You attempted to generate a link for the "tag" route, but did not pass the models required for generating its dynamic segments. You must provide param `id` to `generate`.

[snewcomer]

I put this example here in case we wanted a more general solution vs the ObjectProxy (which more closely resembles Ember-Data relationship)

[rwjblue]

Conceptually this is pretty odd (e.g. if we were going to fall back to use get(model, name) then we shouldn't check name in model at the first branch above)

I think we could try to o something special like:

} else if (isProxy(model)) {
  object[name] = get(model, name);
}

[runspired]

@rwjblue as long as the helper util doesn't check for a symbol-ish thing that EmberData can't easily make use of (e.g. it checks for the well known proxy methods) then I don't see an issue with doing it this way.

[rwjblue]

@runspired ya, its basically anything that uses the proxy mixin

ember.js/packages/@ember/-internals/runtime/lib/mixins/-proxy.js

Line 76 in 23ee5d1

setProxy(this);

[snewcomer]

I could also put this in the first if expression. Up to you if you feel having this final else if is better. Or perhaps it doesn't matter 😄 .