[FEATURE dynamic-helper-and-modifier] Add dynamic helper usage #19309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Dec 15, 2020
packages/ember-template-compiler/lib/plugins/transform-component-invocation.ts
Show resolved
Hide resolved
pzuraq
force-pushed
the
update/bump-vm-enable-dynamic-helpers-components
branch
2 times, most recently
from
7e14be6
to
1bf7fd5
Compare
Enables dynamic helper usage based on either helper definitions directly, or currying helpers with the (helper) keyword.
pzuraq
force-pushed
the
update/bump-vm-enable-dynamic-helpers-components
branch
from
1bf7fd5
to
f8339c3
Compare
|
We were able to fix the issue with component transforms upstream and avoid it altogether, we can remove the transform entirely now 😄 |
pzuraq
changed the title
rwjblue
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to use dynamic helper based on either helper definitions directly, or currying helpers with the
(helper)keyword. Also adds a canary flag for this feature.