Lazily setup the router in non-application tests for <LinkTo> component #19326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR emberjs#19080 fixed the issue where accessing public router service throwing error, however, the PR did not support LinkTo component which uses the internal -routing service. This PR adds similar lazy setup to -routing.router.
xg-wang
force-pushed
the
link-to-router-fix
branch
from
5461413 to
763e756
Compare
|
@dstiers11 @rwjblue can we get this PR merged? |
rwjblue
approved these changes
Jan 13, 2021
|
Thank you! |
xg-wang
added a commit
to xg-wang/super-rentals-tutorial
that referenced
this pull request
Jan 18, 2021
This is no longer needed when emberjs/ember.js#19326 lands in the next release (should be 3.25.0, but I could be wrong)
xg-wang
added a commit
to xg-wang/super-rentals-tutorial
that referenced
this pull request
Feb 10, 2021
This is no longer needed when emberjs/ember.js#19326 lands in the next release (should be 3.25.0, but I could be wrong)
xg-wang
added a commit
to xg-wang/super-rentals-tutorial
that referenced
this pull request
Feb 10, 2021
This is no longer needed when emberjs/ember.js#19326 lands in the next release (should be 3.25.0, but I could be wrong)
xg-wang
added a commit
to xg-wang/super-rentals-tutorial
that referenced
this pull request
Mar 8, 2021
This is no longer needed when emberjs/ember.js#19326 lands in the next release (should be 3.25.0, but I could be wrong)
xg-wang
added a commit
to xg-wang/super-rentals-tutorial
that referenced
this pull request
Mar 8, 2021
This is no longer needed when emberjs/ember.js#19326 lands
chancancode
pushed a commit
to ember-learn/super-rentals
that referenced
this pull request
Mar 8, 2021
This is no longer needed when emberjs/ember.js#19326 lands --- Commit: ember-learn/super-rentals-tutorial@d09b653 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/d09b6539a6a7def6b8a504cc212cad0fcbc39504/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/d09b6539a6a7def6b8a504cc212cad0fcbc39504/checks
chancancode
pushed a commit
to ember-learn/super-rentals
that referenced
this pull request
Mar 8, 2021
This is no longer needed when emberjs/ember.js#19326 lands --- Commit: ember-learn/super-rentals-tutorial@d09b653 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/d09b6539a6a7def6b8a504cc212cad0fcbc39504/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/d09b6539a6a7def6b8a504cc212cad0fcbc39504/checks
chancancode
pushed a commit
to ember-learn/guides-source
that referenced
this pull request
Mar 8, 2021
This is no longer needed when emberjs/ember.js#19326 lands --- Commit: ember-learn/super-rentals-tutorial@d09b653 Script: https://github.com/ember-learn/super-rentals-tutorial/blob/d09b6539a6a7def6b8a504cc212cad0fcbc39504/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/d09b6539a6a7def6b8a504cc212cad0fcbc39504/checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR #19080 fixed the issue where accessing public router service throwing
error, however, the PR did not support LinkTo component which uses the
internal -routing service. This PR adds similar lazy setup to
-routing.router.
Todo
this.owner.setupRouter();for next release