[BUGFIX release] Fix misleading LinkTo error message #19342
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #18640.
An easy way to demonstrate the original problem is to make a route that throws from
serialize
:Before this change, you would see:
Notice that both the message and the stack trace are misleading.
After this change, you would see:
In which the message is not so misleading anymore, and the stack trace points to the real site of the problem.
I also confirmed that this still gives reasonable results for the case of failing to pass enough dynamic parameters. Before:
And after: