[RFC 698] Deprecate <LinkTo> positional arguments
#19345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancancode
commented
Jan 20, 2021
packages/ember-template-compiler/lib/plugins/transform-link-to.ts
Outdated
Show resolved
Hide resolved
chancancode
commented
Jan 20, 2021
packages/ember-template-compiler/lib/plugins/transform-link-to.ts
Outdated
Show resolved
Hide resolved
locks
force-pushed
the
deprecate-link-to-positional-args
branch
3 times, most recently
from
2bf2702 to
e270d6d
Compare
locks
force-pushed
the
deprecate-link-to-positional-args
branch
2 times, most recently
from
2454e25 to
b42f509
Compare
chancancode
commented
Feb 6, 2021
packages/@ember/-internals/glimmer/tests/integration/application/engine-test.js
Outdated
Show resolved
Hide resolved
locks
force-pushed
the
deprecate-link-to-positional-args
branch
2 times, most recently
from
6e966b8 to
733b0a9
Compare
locks
force-pushed
the
deprecate-link-to-positional-args
branch
from
733b0a9 to
a122575
Compare
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement RFC 698
The tests still need to be updated/fixed. I'd like to hand this off if someone else has the bandwidth to do that in the next few days so I can implement another deprecation RFC, but if no one is able to pick it up I'll come back to this after.