Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC 445] Deprecate {{#with}} #19346

Merged
merged 1 commit into from
Jan 20, 2021
Merged

[RFC 445] Deprecate {{#with}} #19346

merged 1 commit into from
Jan 20, 2021

Conversation

chancancode
Copy link
Member

Also transforms {{#with}} into the equivalent combination of {{#let}} and/or {{#if}} to allow removing the legacy upstream code on the Glimmer VM side.

See RFC 445.

Also transforms `{{#with}}` into the equivalent combination of
`{{#let}}` and/or `{{#if}}` to allow removing the legacy upstream
code on the Glimmer VM side.

See [RFC 445](https://github.com/emberjs/rfcs/blob/master/text/0445-deprecate-with.md).
Comment on lines +108 to +115
deprecate(`\`{{#with}}\` is deprecated. ${recommendation} ${sourceInformation}`, false, {
id: 'ember-glimmer.with-syntax',
until: '4.0.0',
for: 'ember-source',
since: {
enabled: '3.26.0-beta.1',
},
});
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd need to add a url to the deprecation guide entry. This can probably be done post-merge and I'd like to hand that (writing the deprecation guide) off to someone else so I can focus on implementing other deprecation RFCs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chancancode chancancode requested a review from rwjblue January 20, 2021 08:52
@rwjblue rwjblue merged commit 8c4504e into master Jan 20, 2021
@rwjblue rwjblue deleted the deprecate-with branch January 20, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants