Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEPRECATION] Deprecates old browser support policy #19359

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Conversation

pzuraq
Copy link
Contributor

@pzuraq pzuraq commented Jan 26, 2021

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to fix the deprecation predicate (a falsey value issues a deprecation, so it was previously deprecating on all but IE11).

@rwjblue
Copy link
Member

rwjblue commented Jan 27, 2021

Will need to be updated to avoid issuing the deprecation on IE11 (or we need to make the "fail on deprecation" setup ignore this specific id).

Also, seems like we have an issue in Node / SSR. The error that is being thrown seems wrong though (I suspect an earlier deprecation causes the assets to be loaded incorrectly, but haven't verified).

* Adds the deprecation specified in
  https://github.com/emberjs/rfcs/blob/master/text/0685-new-browser-support-policy.md
* Updates the test harness to avoid failing CI for deprecations issued
  on IE11
@rwjblue rwjblue merged commit 82f3089 into master Jan 27, 2021
@rwjblue rwjblue deleted the deprecate-ie11 branch January 27, 2021 15:49
@sandstrom
Copy link
Contributor

Good bye IE11. You won't be missed 😄

f3faa371b84b0703c1a53bb0395a3509

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants