[BUGFIX release] Revert deprecation of htmlSafe and isHTMLSafe #19396
Conversation
packages/ember/index.js
Outdated
| Object.defineProperty(Ember.String, 'htmlSafe', { | ||
| enumerable: true, | ||
| configurable: true, | ||
| get() { | ||
| deprecateImportFromString('htmlSafe'); | ||
| return htmlSafe; | ||
| }, | ||
| }); | ||
| Object.defineProperty(Ember.String, 'isHTMLSafe', { | ||
| enumerable: true, | ||
| configurable: true, | ||
| get() { | ||
| deprecateImportFromString('isHTMLSafe'); | ||
| return isHTMLSafe; | ||
| }, | ||
| }); |
There was a problem hiding this comment.
Hmm, don't we still need these properties? Were they already there?
There was a problem hiding this comment.
I moved them up with the rest of of the Ember.String methods: https://github.com/emberjs/ember.js/pull/19396/files#diff-2f99d92a23bae60fccaee9fcfeda8b77ca73723657662cfadfa4d82751045e14R453.
Since we're not calling the deprecation method, I thought they could all be assigned together.
There was a problem hiding this comment.
D'oh! Sorry about that, I totally missed it in the diff.
Since we're not calling the deprecation method, I thought they could all be assigned together.
I think that maybe it would be better to keep the infra around for the deprecation, and change the deprecateImportFromString to pass true to deprecate (with a nice comment explaining that it needs to be changed back to false when we have addressed that issue).
packages/ember/index.js
Outdated
| Object.defineProperty(Ember.String, 'htmlSafe', { | ||
| enumerable: true, | ||
| configurable: true, | ||
| get() { | ||
| deprecateImportFromString('htmlSafe'); | ||
| return htmlSafe; | ||
| }, | ||
| }); | ||
| Object.defineProperty(Ember.String, 'isHTMLSafe', { | ||
| enumerable: true, | ||
| configurable: true, | ||
| get() { | ||
| deprecateImportFromString('isHTMLSafe'); | ||
| return isHTMLSafe; | ||
| }, | ||
| }); |
There was a problem hiding this comment.
D'oh! Sorry about that, I totally missed it in the diff.
Since we're not calling the deprecation method, I thought they could all be assigned together.
I think that maybe it would be better to keep the infra around for the deprecation, and change the deprecateImportFromString to pass true to deprecate (with a nice comment explaining that it needs to be changed back to false when we have addressed that issue).
locks
force-pushed
the
patch-htmlsafe-deprecation
branch
from
b3d8861 to
4ee3d4c
Compare
|
I tried making the tests into |
locks
force-pushed
the
patch-htmlsafe-deprecation
branch
from
01c7dad to
07320fc
Compare
locks
force-pushed
the
patch-htmlsafe-deprecation
branch
from
07320fc to
7f70b81
Compare
rwjblue
changed the title
|
@rwjblue can we get a patch for 3.25 or should we just wait for 3.26? |
|
Yes we plan on back porting this |
Starts addressing #19393.