Add deprecation for Route#render method

[patocallaghan]

Adds deprecation for Route#render. See RFC 418 for more info. This deprecation has the same id/url as Route#renderTemplate as they were part of the same RFC.

id: 'route-render-template'
until: '4.0.0',
url: 'https://deprecations.emberjs.com/v3.x/#toc_route-render-template'
for: 'ember-source',
since: {
  enabled: '3.27.0',
},

[patocallaghan]

Refactors render to be _render, and call that from within renderTemplate and render instead.

[rwjblue]

Let's use the symbol utility method from @ember/-internals/utils to make something more truly private.

[rwjblue]

Implementation generally looks good, only had a couple small suggestions.

[rwjblue]

Let's use the symbol utility method from @ember/-internals/utils to make something more truly private.

[rwjblue]

Lets include some more information in the deprecation message. I'm thinking this.routeName at least...

[patocallaghan]

@rwjblue I think I understand the symbol mechanism. Are you suggesting we do something like the following instead?

const RENDER = symbol('render');

// internal functionality now declared outside the class
function _render(name, options) {
  let renderOptions = buildRenderOptions(this, name, options);
  ROUTE_CONNECTIONS.get(this).push(renderOptions);
  once(this._router, '_setOutlets');
}

class Route extends EmberObject implements IRoute {
  constructor() {
    // ... snip ...
    // Make sure to bind to `this`
    this[RENDER] = _render.bind(this);
  }
  // ... snip ...
  renderTemplate(name, options) {
    this[RENDER]();
  }
}

[rwjblue]

Something more like:

const RENDER = symbol('render');

class Route extends EmberObject implements IRoute {
  [RENDER]() {
    // the implementation here
  }

  render() {
    // issue a deprecation
    return this[RENDER](...arguments);
  }
}

[patocallaghan]

@rwjblue I've incorporated your feedback so I think it should be good to go now

[rwjblue]

Thank you!