Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add remaining Ember modules #19463

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Conversation

pzuraq
Copy link
Contributor

@pzuraq pzuraq commented Mar 16, 2021

Adds all of the remaining Ember modules so that we can remove the
API polyfill. Also updates the tests for re-exporting modules so they
are organized by exported module and also test re-exporting the external
module and not any internal one.

@rwjblue
Copy link
Member

rwjblue commented Mar 16, 2021

Prod tests failed:

Test failed: ember reexports:  Ember exports correctly", source:  (49)
[0316/194220.865590:INFO:CONSOLE(52)] "    Failed assertion: Ember._assertDestroyablesDestroyed is not `undefined`
    at confirmExport (http://localhost:13141/tests/ember-tests.js:116013:16)
    at http://localhost:13141/tests/ember-tests.js:101353:48
    at Array.forEach (<anonymous>)
    at _class._proto.@test Ember exports correctly (http://localhost:13141/tests/ember-tests.js:101344:18)
    at Object.<anonymous> (http://localhost:13141/tests/ember-tests.js:117656:37)
    at runTest (http://localhost:13141/tests/qunit/qunit.js:2251:36)", source:  (52)
[0316/194220.867207:INFO:CONSOLE(52)] "    Failed assertion: Ember._enableDestroyableTracking is not `undefined`
    at confirmExport (http://localhost:13141/tests/ember-tests.js:116013:16)
    at http://localhost:13141/tests/ember-tests.js:101353:48
    at Array.forEach (<anonymous>)
    at _class._proto.@test Ember exports correctly (http://localhost:13141/tests/ember-tests.js:101344:18)
    at Object.<anonymous> (http://localhost:13141/tests/ember-tests.js:117656:37)
    at runTest (http://localhost:13141/tests/qunit/qunit.js:2251:36)", source:  (52)

@pzuraq pzuraq force-pushed the add-remaining-real-ember-modules branch from f8d695b to 62dabfa Compare March 16, 2021 20:03
packages/@ember/-internals/bootstrap/index.js Outdated Show resolved Hide resolved
packages/@ember/application/deprecations.ts Outdated Show resolved Hide resolved
packages/@ember/helper/index.ts Show resolved Hide resolved
packages/ember/index.js Outdated Show resolved Hide resolved
packages/ember/index.js Outdated Show resolved Hide resolved
@pzuraq pzuraq force-pushed the add-remaining-real-ember-modules branch 4 times, most recently from 49df5a1 to fb8f022 Compare March 16, 2021 21:31
Adds all of the remaining Ember modules so that we can remove the
API polyfill. Also updates the tests for re-exporting modules so they
are organized by exported module and also test re-exporting the external
module and not any internal one.
@pzuraq pzuraq force-pushed the add-remaining-real-ember-modules branch from fb8f022 to a61143b Compare March 16, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants