[FEATURE] Remove globals namespace based toString #19467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
force-pushed
the
remove-global-namespace-debug-string-generation
branch
5 times, most recently
from
7476d24
to
bd0c898
Compare
Removes the legacy `toString` behavior and replaces it with using the factory for/container system for classes when possible, and just `unknown` when not.
pzuraq
force-pushed
the
remove-global-namespace-debug-string-generation
branch
from
bd0c898
to
a80b54e
Compare
rwjblue
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the legacy
toStringbehavior and replaces it with using thefactory for/container system for classes when possible, and just
unknownwhen not.