[DONT BACKPORT][BUGFIX lts] Make {{hash}} object properties settable #19548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
changed the title
pzuraq
changed the title
Makes all {{hash}} object properties settable, but deprecates setting
them.
pzuraq
force-pushed
the
bugfix/allow-all-values-on-hash-to-be-set
branch
from
b6589c4
to
ec4c034
Compare
rwjblue
approved these changes
May 20, 2021
simonihmig
added a commit
to simonihmig/ember-focus-trap
that referenced
this pull request
May 26, 2021
Recent CI runs of ember-bootstrap for Ember canary and beta started to fail because of deprecations, raised by mutating the `{{hash}}` object inside of this modifier when it is used to pass `focusTrapOptions` as in https://github.com/josemarluedke/ember-focus-trap#with-focus-trap-options. This deprecation was recently added to Ember in emberjs/ember.js#19548. The change here treats that object as immutable.
This was referenced May 26, 2021
pzuraq
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes all {{hash}} object properties settable, but deprecates setting them. See glimmerjs/glimmer-vm#1298 (comment) for more details.
This PR/fix ended up not working out, so we're not backporting