Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX release] Extend transitionTo deprecation #19571

Merged
merged 1 commit into from
May 29, 2021

Conversation

btecu
Copy link
Contributor

@btecu btecu commented May 28, 2021

Closes #19570.

@kategengler kategengler changed the title Extend transitionTo deprecation [BUGFIX release] Extend transitionTo deprecation May 28, 2021
@kategengler kategengler changed the base branch from v4-cleanup to master May 28, 2021 22:27
@kategengler kategengler changed the base branch from master to v4-cleanup May 28, 2021 22:27
@kategengler
Copy link
Member

Thanks @btecu, could you possibly rebase to the master branch?

@btecu btecu force-pushed the transition-deprecaton branch from 80d790a to 926452f Compare May 28, 2021 22:34
@btecu btecu changed the base branch from v4-cleanup to master May 28, 2021 22:35
@btecu
Copy link
Contributor Author

btecu commented May 28, 2021

@kategengler done.

@kategengler kategengler merged commit cf7c1bd into emberjs:master May 29, 2021
@kategengler
Copy link
Member

Merging because the build is green -- status checks here seem confused and waiting on a check that no longer exists.

Thanks @btecu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move route/controller transition method deprecations to until: 5.0.0
2 participants