Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove meta-destruction-apis #19655

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Remove meta-destruction-apis #19655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 2 additions & 68 deletions packages/@ember/-internals/meta/lib/meta.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { symbol, toString } from '@ember/-internals/utils';
import { assert, deprecate } from '@ember/debug';
import { isDestroyed, isDestroying } from '@glimmer/destroyable';
import { assert } from '@ember/debug';
import { isDestroyed } from '@glimmer/destroyable';
import { DEBUG } from '@glimmer/env';
import { Revision, UpdatableTag } from '@glimmer/validator';

Expand Down Expand Up @@ -133,72 +133,6 @@ export class Meta {
return parent;
}

// These methods are here to prevent errors in legacy compat with some addons
// that used them as intimate API
setSourceDestroying() {
deprecate(
'setSourceDestroying is deprecated, use the destroy() API to destroy the object directly instead',
false,
{
id: 'meta-destruction-apis',
until: '3.25.0',
for: 'ember-source',
since: {
enabled: '3.21.0',
},
}
);
}

setSourceDestroyed() {
deprecate(
'setSourceDestroyed is deprecated, use the destroy() API to destroy the object directly instead',
false,
{
id: 'meta-destruction-apis',
until: '3.25.0',
for: 'ember-source',
since: {
enabled: '3.21.0',
},
}
);
}

isSourceDestroying() {
deprecate(
'isSourceDestroying is deprecated, use the isDestroying() API to check the object destruction state directly instead',
false,
{
id: 'meta-destruction-apis',
until: '3.25.0',
for: 'ember-source',
since: {
enabled: '3.21.0',
},
}
);

return isDestroying(this.source);
}

isSourceDestroyed() {
deprecate(
'isSourceDestroyed is deprecated, use the isDestroyed() API to check the object destruction state directly instead',
false,
{
id: 'meta-destruction-apis',
until: '3.25.0',
for: 'ember-source',
since: {
enabled: '3.21.0',
},
}
);

return isDestroyed(this.source);
}

setInitializing() {
this._isInit = true;
}
Expand Down