Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ability to override computed property #19674

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Remove ability to override computed property #19674

merged 1 commit into from
Jul 23, 2021

Conversation

nlfurniss
Copy link
Contributor

Part of #19617. Deprecation guide

Most tests seem fine, though not sure if this one still has value..

@mixonic mixonic mentioned this pull request Jul 23, 2021
Closed
58 tasks
@nlfurniss nlfurniss requested a review from mixonic July 23, 2021 01:50
@mixonic mixonic merged commit fc09fef into emberjs:master Jul 23, 2021
@nlfurniss nlfurniss deleted the remove-computed-property-override branch July 23, 2021 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mixonic mixonic Awaiting requested review from mixonic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nlfurniss @mixonic