Remove window.Ember global #19678
Merged
Remove window.Ember global #19678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixonic
force-pushed
the
mixonic/drop-global
branch
from
b487d81
to
86041d2
Compare
mixonic
force-pushed
the
mixonic/drop-global
branch
from
86041d2
to
5bbe4b9
Compare
mixonic
requested review from
rwjblue and
chancancode
and removed request for
rwjblue
mixonic
commented
Jul 23, 2021
| @@ -43,7 +43,7 @@ function buildSandboxContext(precompile) { | |||
| URL, | |||
|
|
|||
| // Convince jQuery not to assume it's in a browser | |||
| module: { exports: {} }, | |||
| module: { exports: {}, require() {} }, | |||
There was a problem hiding this comment.
This is maybe the most suspicious change in here. As these tests are simply executing scripts in a context, they don't directly use any module system (CommonJS or ES). Adding require() {} to the exports fools Ember into thinking this is a CommonJS env (which is effectively what this line was doing anyway) and thus Ember sets .exports to be Ember. This hack only works for one this-which-exports-via-CommonJS in a context.
I'm not familiar enough with how this code runs in Fastboot to know if this is a meaningful test. cc @rwjblue
There was a problem hiding this comment.
@rwjblue suggested this should land, and that if Fastboot as a follow up we can address it during the beta.
kategengler
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #19617