Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX release] fix router test regression in urlFor and recognize #19733

Merged
merged 1 commit into from
Aug 30, 2021
Merged

[BUGFIX release] fix router test regression in urlFor and recognize #19733

merged 1 commit into from
Aug 30, 2021

Commits on Aug 27, 2021

  1. [BUGFIX release] fix router test regression in urlFor and recognize

    As part of the improvements made between 3.24 and 3.28, the router
    microlib is now lazily loaded. When these changes were made, there were
    a couple cases where it *should* be possible to access router state in
    a non-application test (integration etc.) but it currently is not
    because the router is not necessarily set up. Since `setupRouter` is
    idempotent, call it in those functions so that if it is *not* set up,
    it gets set up, and otherwise it will continue working as expected.
    chriskrycho committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    9f61c7a View commit details
    Browse the repository at this point in the history