Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pass falsy locals to glimmer precompile #19798

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Don't pass falsy locals to glimmer precompile #19798

merged 1 commit into from
Oct 22, 2021

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Oct 22, 2021

Fixes #19797.

@ef4
Copy link
Contributor Author

ef4 commented Oct 22, 2021

This and glimmerjs/glimmer-vm#1354 should probably get released together as 3.28.3.

@rwjblue rwjblue merged commit b83b205 into master Oct 22, 2021
@rwjblue rwjblue deleted the guard-null-locals branch October 22, 2021 10:48
@rwjblue rwjblue mentioned this pull request Oct 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Template compiler crash on 3.28.2
2 participants
@ef4 @rwjblue