[CLEANUP beta] Remove check to see if ember is defined as a Bower dependency
#19838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixonic
reviewed
Nov 14, 2021
lib/index.js
Outdated
| this.ui.writeWarnLine( | ||
| 'Ember.js is now provided by node_module `ember-source`, please remove it from bower' | ||
| throw new SilentError( | ||
| 'Ember.js is now provided by the `ember-source` node module, please remove `ember` from your `bower.json` file.' | ||
| ); | ||
| } |
There was a problem hiding this comment.
Can we remove the whole if ('ember' in this.project.bowerDependencies()) { block? cc @rwjblue ?
There was a problem hiding this comment.
Sure, let me know if I should remove.
bertdeblock
force-pushed
the
cleanup/throw-when-ember-is-defined-in-bower-file
branch
from
d601591
to
58c28dc
Compare
bertdeblock
changed the title
ember is defined in bower.json fileember is defined as a Bower dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #19617.