Commits on Mar 16, 2022

1. [BUGFIX LTS] remove bad setFactoryFor call …

   This call *attempted* to avoid setting the `INIT_FACTORY` on items
   which did not need it (specifically, it avoided setting it on things
   which were not instantiable), but ultimately failed to do. It was
   ultimately setting the new `FactoryManager` instance as the
   `INIT_FACTORY` value on each instantiable object, which includes
   classes and not just class instances, since objects are only treated as
   non-instantiable when they explicitly specify `instantiate: false`.
   
   The net was a memory leak: the routing service *class* ended up with an
   `INIT_FACTORY` pointing to a `FactoryManager` instance which in turn
   always had a `container` on it, which meant that there was a cycle (the
   container also referenced the service) and thus a leak. This affects
   both tests and FastBoot, where we construct new instances of the
   service whenever we call the `visit` API.

   

   chriskrycho committed Mar 16, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for fc7bfe7
   • Browse repository at this point

   Copy the full SHA

   fc7bfe7 View commit details

   Browse the repository at this point in the history

2. [BUGFIX beta] remove unneeded setFactoryFor(this, this) …

   Identified as part of the work on #20025, this particular `setFactoryFor`
   was needed at one time but is now defunct. Remove it.

   

   chriskrycho committed Mar 16, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 2590b2b
   • Browse repository at this point

   Copy the full SHA

   2590b2b View commit details

   Browse the repository at this point in the history